mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58980: Passed '--default_container_info' to the command executor.
Date Thu, 04 May 2017 12:27:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58980/#review173894
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58980]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 4, 2017, 12:12 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58980/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 12:12 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: mesos-7007
>     https://issues.apache.org/jira/browse/mesos-7007
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When there is no container info in the task info, copy that from the executor info so
the command executor can set up the container correctly.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae

> 
> 
> Diff: https://reviews.apache.org/r/58980/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> Manually tested on the scenario provided in mesos-7007.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message