mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 58869: Bumped the default timeout value for docker volume detach operation.
Date Sat, 29 Apr 2017 00:37:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58869/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Repository: mesos


Description
-------

A volume detach operation can be very time consuming in some cloud
environment. In extreme cases, the detach can take up to 20 minutes.
Since 'Unmount' in Docker Volume Driver Interface (DVDI) is not
idempotent, the container orchestrator (i.e., Mesos) cannot safely
retry the operation. As a result, we don't have much flexibility here.
This patch increases the timeout value hoping the operation will
finish within this new timeout value in most of the cases.


Diffs
-----

  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 18a8066b064835cbd7a2cef6d1a43462bdd5e87c



Diff: https://reviews.apache.org/r/58869/diff/1/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message