mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58824: Disabled unit test relying on AliCloud Registry.
Date Fri, 28 Apr 2017 17:09:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58824/#review173344
-----------------------------------------------------------




src/tests/containerizer/provisioner_docker_tests.cpp
Line 464 (original)
<https://reviews.apache.org/r/58824/#comment246364>

    Let's comment it out, instead of removing it. Ideally, if we can control this by a testing
flag, that'll be even better.


- Jie Yu


On April 27, 2017, 11:16 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58824/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 11:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Disabled unit test relying on AliCloud Registry.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 4341621767a9fa5be2c66e77ef60f0c65dae58ca

> 
> 
> Diff: https://reviews.apache.org/r/58824/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message