mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.
Date Wed, 26 Apr 2017 17:35:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 26, 2017, 5:35 p.m.)

Review request for mesos, Benjamin Mahler and Kapil Arya.


Tweaked comments, rebase.

Summary (updated)

Enhanced stout's Version to support prerelease and build labels.

Bugs: MESOS-1987

Repository: mesos


Previously, Stout's `Version` abstraction only supported a subset of
Semver: version numbers with three numeric components (an optional
trailing "label" with a leading hyphen was supported but ignored).

This commit adds support for SemVer 2.0.0, which defines two additional
optional fields: a "prerelease label" and a "build metadata label",
e.g., "1.2.3-alpha.1+foo". Both labels consist of a series of
dot-separated identifiers.

Diffs (updated)

  3rdparty/stout/include/stout/version.hpp 7717c85b95d29cefe8f19f3cada4b7402d4d446f 
  3rdparty/stout/tests/version_tests.cpp 724ed2292fdd3c5f4c98facf82260078b66a0e97 




`make check`


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message