mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 58706: Improved unit tests for Version in stout.
Date Wed, 26 Apr 2017 17:35:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58706/
-----------------------------------------------------------

(Updated April 26, 2017, 5:35 p.m.)


Review request for mesos, Benjamin Mahler and Kapil Arya.


Changes
-------

Addressed review comments, fix compile error with old G++.


Bugs: MESOS-1987
    https://issues.apache.org/jira/browse/MESOS-1987


Repository: mesos


Description
-------

Switch to table-based test cases, validate that version parsing produces
the expected results more precisely.


Diffs (updated)
-----

  3rdparty/stout/tests/version_tests.cpp 724ed2292fdd3c5f4c98facf82260078b66a0e97 


Diff: https://reviews.apache.org/r/58706/diff/3/

Changes: https://reviews.apache.org/r/58706/diff/2-3/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message