mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 53842: Add role specific metrics for sorting runs.
Date Tue, 25 Apr 2017 17:31:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/#review172952
-----------------------------------------------------------


Ship it!




The code looks fine. As per the other revires this needs documentation.

Please update the metric names in the commit. The metrics are `allocator/mesos/frameworks/<role>`
not `allocator/mesos/frameworks/role/<role>`.

- James Peach


On April 19, 2017, 8:52 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53842/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 8:52 p.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6579
>     https://issues.apache.org/jira/browse/MESOS-6579
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the following 2 metrics which is maintained on a role level
> (as long as there is at least one framework of that role):
> a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
>    level sorts (based on role) in DRF Sorter.
> b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
>    level sorts (based on role) in DRF Sorter.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 646f66e67d9c6b8c61fc6e6558a1db976a44c126

>   src/master/allocator/mesos/hierarchical.cpp 0059ccead90f32491591990c791e7fa905a864b7

>   src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630

> 
> 
> Diff: https://reviews.apache.org/r/53842/diff/3/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message