mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles.
Date Thu, 20 Apr 2017 18:04:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/#review172526
-----------------------------------------------------------



If I understand this correctly, this is publishing a time series of the idle time between
allocator runs. Is that correct? If so, what insight does this metric give and how should
operators interpret it? Why is a simple counter of allocator runs not sufficient?

- James Peach


On April 19, 2017, 8:51 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53840/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 8:51 p.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6579
>     https://issues.apache.org/jira/browse/MESOS-6579
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a metric 'allocator/mesos/allocation_run_interval_ms' which
> tracks the latency between consecutive allocation cycles.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 0059ccead90f32491591990c791e7fa905a864b7

>   src/master/allocator/mesos/metrics.hpp ce486eb079dc44bf0bbfad8668426c7ae87c97b3 
>   src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 
>   src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630

> 
> 
> Diff: https://reviews.apache.org/r/53840/diff/3/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message