mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <>
Subject Re: Review Request 58512: Avoid a crash in HTTP decoder.
Date Thu, 20 Apr 2017 17:18:23 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 20, 2017, 5:18 p.m.)

Review request for mesos, Anand Mazumdar, James Peach, and Jiang Yan Xu.

Bugs: MESOS-7400

Repository: mesos


If the callback `on_headers_complete()` fails, the decoder's writer
object is `None()`. So, when the callback `on_message_complete()` is
called, we should not crash in that case.
Note that the `CHECK(decoder->writer)` is valid for the callback
`on_body()` is valid since this callback is called only on a success
in `on_headers_complete()` callback.

Diffs (updated)

  3rdparty/libprocess/src/decoder.hpp 4c779d42548958e610142438a57529ccb4478053 
  3rdparty/libprocess/src/tests/decoder_tests.cpp c0efef571815752cc28e5a0dc7a07adc82bb31d5




All tests passed.


Anindya Sinha

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message