mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 58508: Introduced method `Resources::inheritable` to aggregate reservations.
Date Thu, 20 Apr 2017 16:18:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58508/
-----------------------------------------------------------

(Updated April 21, 2017, 12:18 a.m.)


Review request for mesos and Michael Park.


Changes
-------

address comments from mcypark.


Bugs: MESOS-7149
    https://issues.apache.org/jira/browse/MESOS-7149


Repository: mesos


Description
-------

A reservation is inheritable by 'role' iff:
 - it is reserved to ancestor of 'role' in hierarchy, OR
 - it is reserved to 'role' itself.

This is a helper function for reservation delegate, where reserved
resources can be 'delegated' downwards in the hierarchy.


Diffs (updated)
-----

  include/mesos/resources.hpp 74583e3c784f22b45cce81f07c5a69b339e1684d 
  src/common/resources.cpp 77bac0c4390da905016a942991b14a79877f8455 
  src/tests/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be 


Diff: https://reviews.apache.org/r/58508/diff/2/

Changes: https://reviews.apache.org/r/58508/diff/1-2/


Testing
-------

make check


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message