mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.
Date Wed, 19 Apr 2017 18:20:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58448/
-----------------------------------------------------------

(Updated April 19, 2017, 6:20 p.m.)


Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.


Changes
-------

Add ZooKeeper bug.


Bugs: ZOOKEEPER-2756
    https://issues.apache.org/jira/browse/ZOOKEEPER-2756


Repository: mesos


Description
-------

This unblocks us from building exclusively with VS 2017. The previous
patch to ZooKeeper only added VS 2015 support. This patch replaces it
with a CMake build system that will generate whichever solution we need
for Windows (and can replace the Autotools system on Linux).

We're updating to 3.5.2-alpha as the existing 3.5.1 rebundle was a
source tarball, and so missing the necessary generated files. The most
currently used version was based off a random commit. 3.5.2-alpha is the
latest 3.5.x release of ZooKeeper (3.5.x itself is alpha, 3.5.2 is
semi-stable, in comparison to 3.5.3 which is in RC).


Diffs
-----

  3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake c60652688a23f8628f133b7890ff39e38fc8ae94 
  3rdparty/cmake/Versions.cmake 912726351ff744dd839b8d1c8d64dcc373d879be 
  3rdparty/zookeeper-3.5.2-alpha.patch PRE-CREATION 


Diff: https://reviews.apache.org/r/58448/diff/1/


Testing
-------

cmake and make check on Linux
stout-tests, libprocess-tests, and mesos-tests on Windows: all tests passed. (Note: my machine
updated to the Creators Update today, disabling long path support; the previous way to enable
it doesn't seem to work, so I re-ran the failed tests on a machine that hadn't updated and
still had long path support, they passed).

Also tested the build on a clean machine with nothing but the VS 2017 build tools (no IDE,
no prior VS installations); mesos-tests builds no problem.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message