mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.
Date Fri, 14 Apr 2017 00:24:33 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 14, 2017, 12:24 a.m.)

Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.

Bugs: MESOS-5028

Repository: mesos


When a layer overwrites a directory with a regular file or symbolic link
(or vice versa), the old dir/file need to be removed before copying the
layer into the rootfs. This is processed together with whiteout:
The copy provisioner find all files to remove, including files
marked as whiteout and the files described above, and remove them
before the copy process.

Diffs (updated)

  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 584cc6524f81cc1bc231b105507dbfe51fec991d




make check
Manually tested on the following images:


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message