mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.
Date Thu, 13 Apr 2017 22:03:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57898/
-----------------------------------------------------------

(Updated April 13, 2017, 10:03 p.m.)


Review request for mesos, Jeff Coffler, Joseph Wu, and Michael Park.


Changes
-------

Update bug since it was pulled out of the task.


Bugs: MESOS-7391
    https://issues.apache.org/jira/browse/MESOS-7391


Repository: mesos


Description
-------

Specifically this checks if the generator used did not match "Visual
Studio 15 2017", which Mesos prefers. Note that the `CMAKE_GENERATOR`
variable is expanded fully even when shorthand is used, e.g. `-G"Visual
Studio 15"` will correctly match.


Diffs
-----

  cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 


Diff: https://reviews.apache.org/r/57898/diff/1/


Testing
-------

Tested using different generators on Windows. Warning is displayed when using `-G"Visual Studio
14"`, `-G"Visual Studio 14 2015"`, and `-G"Visual Studio 14 2015 Win64"`, but not when using
`-G"Visual Studio 15"`, `-G"Visual Studio 15 2017"`, or `-G"Visual Studio 15 2017 Win64"`.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message