mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 58373: Updated 'Checker' to authenticate with agent operator API.
Date Wed, 12 Apr 2017 16:37:43 GMT


> On April 12, 2017, 9:53 a.m., Alexander Rukletsov wrote:
> > src/checks/checker.cpp
> > Lines 207 (patched)
> > <https://reviews.apache.org/r/58373/diff/1/?file=1689478#file1689478line207>
> >
> >     Is pass-by-value intended?

Yea I did intend to store a copy of the authorization header here in the `CheckerProcess`.
I guess the other option is to store a reference and rely on the copy stored within the default
executor? I'd prefer to keep the process's context encapsulated here to avoid possible thread
safety issues, and we do pass the authorizationHeader parameter by reference when creating
the process via `create()`. Dropping for now.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58373/#review171697
-----------------------------------------------------------


On April 12, 2017, 9:21 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58373/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 9:21 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Gastón Kleiman, and Vinod
Kone.
> 
> 
> Bugs: MESOS-7377
>     https://issues.apache.org/jira/browse/MESOS-7377
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the `Checker` to permit initialization with
> an authorization header, which it will provide to the agent
> operator API for authentication when present.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.hpp fb939d85dbec2bf7e81e0c11518ccecddc5a7a11 
>   src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 
> 
> 
> Diff: https://reviews.apache.org/r/58373/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message