mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <>
Subject Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
Date Wed, 12 Apr 2017 09:07:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 12, 2017, 9:07 a.m.)

Review request for mesos, Joseph Wu and Kevin Klues.

Bugs: MESOS-7269

Repository: mesos

Description (updated)

These settings were previously in
We now use a TOML file containing the configuration, this
format has been chosen because:
  * It supports comments.
  * It is well-specified.
  * It allows logical grouping.
  * It maps ubiquitous data types.
The config file environment variable, previously
change follows the design doc about the new CLI.
The environement variable `MESOS_CLI_PLUGINS` is not used
anymore as plugins can be added using the TOML file instead.

Diffs (updated)

  src/cli_new/ 0e60515b71192ce1a544711948a5c17a6f9002af 
  src/cli_new/bin/ 2f6162edc1722054bc44ad25956e6fe666d36c7f 
  src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf 




Tested manually, PEP8 and Pylint used to make sure that the code style is correct.


Armand Grillet

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message