mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 58185: Add a common HTTP request log helper function.
Date Thu, 06 Apr 2017 16:56:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58185/#review171225
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp
Lines 673 (patched)
<https://reviews.apache.org/r/58185/#comment244105>

    hmm, these logging additions don't align with the review description:
    
    "Consolidate the master and agent HTTP request log helper
    functions into common code."
    
    Can you do them in a separate review?


- Anand Mazumdar


On April 5, 2017, 9:57 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58185/
> -----------------------------------------------------------
> 
> (Updated April 5, 2017, 9:57 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-7340
>     https://issues.apache.org/jira/browse/MESOS-7340
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consolidate the master and agent HTTP request log helper
> functions into common code.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp b6e61f7f7f8ebcf5b25a37684cae06cb96188478 
>   src/common/http.cpp 89133e0175ffb792ae95705315844a32550470a1 
>   src/master/http.cpp 6cf9d350446d1b2d4a6e67d552217daff32657ff 
>   src/master/master.hpp 1b077424373d6e195e4ab29e150dedbc3f3f95ab 
>   src/master/master.cpp 6a6a570e52d21bfb2443f981e3d7faf8c36f74bc 
>   src/slave/http.cpp e253ce9749fc8a03c21dac1ba0e6efe09311414b 
>   src/slave/slave.hpp e4f46d42b3c0d0f09cff2d896abf6b84aed6c396 
>   src/slave/slave.cpp 65e4a67888fe908e5b2f6ca2ecc9e3a5b9958b2e 
> 
> 
> Diff: https://reviews.apache.org/r/58185/diff/2/
> 
> 
> Testing
> -------
> 
> Make check (Fedora 25). Manual inspection of log output.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message