mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error.
Date Tue, 28 Feb 2017 23:16:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53666/
-----------------------------------------------------------

(Updated Feb. 28, 2017, 11:16 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
-------

Rebased.


Bugs: MESOS-6489
    https://issues.apache.org/jira/browse/MESOS-6489


Repository: mesos


Description
-------

Added a `continueOnError` attribute to cgroups `Destroyer` to allow
cgroups cleanup to continue incase of any error. The linux launcher
continues cleanup of cgroups even if there is an error. However, if
the top level cgroup is actually removed, it treats it as a success.


Diffs (updated)
-----

  src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d 
  src/linux/cgroups.cpp 3a853297eaccc86e55888da21f292f5e37c88733 
  src/slave/containerizer/mesos/linux_launcher.cpp a3409dc64435e002072b9b458a5fda0564214f28


Diff: https://reviews.apache.org/r/53666/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message