mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57160: Added 'override' to function declarations in 'LibeventSSLSocketImpl'.
Date Tue, 28 Feb 2017 22:37:00 GMT


> On Feb. 28, 2017, 10:31 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/libevent_ssl_socket.hpp, lines 47-48
> > <https://reviews.apache.org/r/57160/diff/2/?file=1652008#file1652008line47>
> >
> >     With the removal of `virtual`, this fits on one line again :)

doh! thx. I was about to update, but I see you've already submitted :)


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57160/#review167164
-----------------------------------------------------------


On Feb. 28, 2017, 8:51 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57160/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 8:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Inconsistent use of the `override` keyword in
> `LibeventSSLSocketImpl` was causing warnings during
> clang builds. This patch makes use of the keyword
> across all relevant declarations in the class.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.hpp e589a04d14378f265a8fca871c9f5b0c577f5713

> 
> Diff: https://reviews.apache.org/r/57160/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message