mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 57132: Updated WebUI to display roles.
Date Tue, 28 Feb 2017 22:34:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57132/#review167165
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57013, 57132]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 28, 2017, 5:25 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57132/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 5:25 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6657
>     https://issues.apache.org/jira/browse/MESOS-6657
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With support of multi-tenancy in Mesos, WebUI needs to be updated
> to correctly display role information.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297 
>   src/webui/master/static/agent_executor.html 95e921d1c3ca0f005e3eb3f79eb0d9a70a3b3f91

>   src/webui/master/static/agent_framework.html 806ab06063dcf62cd6d1d7913840ed83141bd1eb

>   src/webui/master/static/framework.html 37e0b31ac90e877b70f315143b7411fadeeeeec6 
>   src/webui/master/static/frameworks.html 0c6fc1c37e0ab49fed64aaa861dfcbaab7f38e0e 
>   src/webui/master/static/js/controllers.js 2ea8275cb5fffa2344474ebfcf9277fe92165a92

>   src/webui/master/static/offers.html 181fc2deabef3faec36785e7fcdbc37465668bec 
> 
> Diff: https://reviews.apache.org/r/57132/diff/
> 
> 
> Testing
> -------
> 
> manually test by launching new master with both new/old agent, and inspect WebUI to see
roles.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message