mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 57160: Added 'override' to function declarations in 'LibeventSSLSocketImpl'.
Date Tue, 28 Feb 2017 22:31:41 GMT


> On Feb. 28, 2017, 12:27 p.m., Benjamin Bannier wrote:
> > This lgtm. I believe that even applying `override` incompletely can prevent bad
mistakes, but am unsure if we are willing to tolerate inconsistencies in the Mesos code base
at all. What's your stance on this Joseph?

Since the plan is to eventually have `override` on all overriden functions, I find it better
to get there incrementally than not-at-all.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57160/#review167139
-----------------------------------------------------------


On Feb. 28, 2017, 12:51 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57160/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 12:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Inconsistent use of the `override` keyword in
> `LibeventSSLSocketImpl` was causing warnings during
> clang builds. This patch makes use of the keyword
> across all relevant declarations in the class.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.hpp e589a04d14378f265a8fca871c9f5b0c577f5713

> 
> Diff: https://reviews.apache.org/r/57160/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message