mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57160: Added 'override' to function declarations in 'LibeventSSLSocketImpl'.
Date Tue, 28 Feb 2017 20:51:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57160/
-----------------------------------------------------------

(Updated Feb. 28, 2017, 8:51 p.m.)


Review request for mesos, Benjamin Bannier and Joseph Wu.


Changes
-------

Addressed comments.


Repository: mesos


Description
-------

Inconsistent use of the `override` keyword in
`LibeventSSLSocketImpl` was causing warnings during
clang builds. This patch makes use of the keyword
across all relevant declarations in the class.


Diffs (updated)
-----

  3rdparty/libprocess/src/libevent_ssl_socket.hpp e589a04d14378f265a8fca871c9f5b0c577f5713


Diff: https://reviews.apache.org/r/57160/diff/


Testing
-------

`make check`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message