mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 57157: Cleaned up `using` statements.
Date Tue, 28 Feb 2017 20:07:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57157/
-----------------------------------------------------------

(Updated Feb. 28, 2017, 8:07 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Fix compilation on Linux.


Repository: mesos


Description
-------

A source file should typically not contain both `using xyz::foo` and
`xyz::foo`.


Diffs (updated)
-----

  src/linux/capabilities.cpp 9f46bd0a34d35d8295b1899a7ba67d85c3c24348 
  src/master/weights_handler.cpp 4f6a4cd29d27b64cbc9ee6d8909f79812313b681 
  src/slave/containerizer/docker.cpp 7d801fb17565a5298e8e3c5b430e070e12473680 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.cpp 2608df1aeabfd2b26f2786eaab3d2a47c2f5710d

  src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65

  src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
d0cf80b82cb4c9d224bd0c9ec1e11077e05ce7f5 
  src/slave/containerizer/mesos/linux_launcher.cpp a3409dc64435e002072b9b458a5fda0564214f28

  src/slave/containerizer/mesos/paths.cpp c1770cefe0287ce994eec6979db41201148ef3fb 
  src/slave/flags.cpp 8de2643ea6cd775636e91af989b596fa7a0f9abc 
  src/tests/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d 
  src/tests/containerizer/mesos_containerizer_tests.cpp 039f197ece893fdf95c25fe60bb827fa2d7a3cbf

  src/tests/containerizer/rootfs.cpp 513c1b544f9e5239fa2a8e8ebedc3d84a6384ba3 

Diff: https://reviews.apache.org/r/57157/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message