mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56813: Updated master handlers to use the 'Principal' type.
Date Tue, 28 Feb 2017 19:38:01 GMT


> On Feb. 28, 2017, 1:38 p.m., Alexander Rojas wrote:
> > src/master/http.cpp, lines 2224-2227
> > <https://reviews.apache.org/r/56813/diff/5/?file=1651003#file1651003line2224>
> >
> >     This line didn't need modification. However it does raises the issue of the
signature of `validation::operation::validate()`. The common pattern in Mesos is to use a
default parameter in the declaration, like:
> >     
> >     ```c++
> >     Option<Error> validate(
> >         const Offer::Operation::Reserve& reserve,
> >         const Option<string>& principal,
> >         const Option<FrameworkInfo>& frameworkInfo = None())
> >     ```
> >     
> >     so that the caller doesn't need to do it. Doing a grep on the srouce code in
over a hundred instances of that pattern.
> >     
> >     Could you quickly fix that?
> 
> Greg Mann wrote:
>     Sure thing, I'll follow-up with another patch and leave a link here.

Follow-up review here: https://reviews.apache.org/r/57158/


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56813/#review167059
-----------------------------------------------------------


On Feb. 28, 2017, 6:34 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56813/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 6:34 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and
Vinod Kone.
> 
> 
> Bugs: MESOS-7003
>     https://issues.apache.org/jira/browse/MESOS-7003
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the HTTP endpoint handlers in the
> master process to accept the `Principal` type instead
> of an `Option<string>& principal`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088 
>   src/master/master.hpp 764adb18ddf09b62529c5c96f8e4dfaf7803483e 
>   src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942 
>   src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a 
>   src/master/registrar.cpp d7134eea34102ab7b24d2f0131363bdd9005cfd3 
>   src/master/weights_handler.cpp 4f6a4cd29d27b64cbc9ee6d8909f79812313b681 
> 
> Diff: https://reviews.apache.org/r/56813/diff/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message