mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`.
Date Tue, 28 Feb 2017 03:22:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57108/#review166994
-----------------------------------------------------------


Fix it, then Ship it!




Looks like we can move out the `MasterTest.MultiRoleSchedulerUpgrade` test and check the master
and agent's endpoints to validate that the framework info was updated correctly.


src/slave/slave.cpp (line 2819)
<https://reviews.apache.org/r/57108/#comment239100>

    How about "Ignoring info update for framework <ID>"?



src/slave/slave.cpp (line 2826)
<https://reviews.apache.org/r/57108/#comment239101>

    Ditto here.



src/slave/slave.cpp (lines 2830 - 2835)
<https://reviews.apache.org/r/57108/#comment239099>

    Hm.. we should consolidate these two log lines, here's a suggestion:
    
    "Updating info for framework <ID>"
    
    Also note that the PID is empty for http schedulers, so we could probably have two variants
using a ternary:
    
    "Updating info for framework <ID>"
    "Updating info for framework <ID> with pid updated to <PID>"


- Benjamin Mahler


On Feb. 27, 2017, 10:15 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57108/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 10:15 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
>     https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Populates the `FrameworkInfo` field added to `UpdateFrameworkMessage`,
> and propagated necessary changes to message handlers.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942 
>   src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2 
>   src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a 
>   src/tests/slave_recovery_tests.cpp 0e295915fea0a7314e173857249bd8726eeccd76 
>   src/tests/slave_tests.cpp 3731c7607d5e49f3000c4863b1999851fac45705 
> 
> Diff: https://reviews.apache.org/r/57108/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message