mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 56527: Disallowed some special path components in IDs.
Date Thu, 23 Feb 2017 21:33:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56527/#review166578
-----------------------------------------------------------



Patch looks great!

Reviews applied: [56526, 56527]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 23, 2017, 7:30 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56527/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2017, 7:30 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-7086
>     https://issues.apache.org/jira/browse/MESOS-7086
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Such IDs should lead to surprising or even dangerous agent side
> directory structure.
> 
> 
> Diffs
> -----
> 
>   src/common/validation.cpp 028679d733d1aab65890d3782f18be0ddf3b05e9 
>   src/tests/master_validation_tests.cpp 53771f6b5492009fe75cbbfc03a2b542856c1070 
>   src/tests/slave_validation_tests.cpp 588c5b2a6b3528bbf7af8e724bc5813b05678bfb 
> 
> Diff: https://reviews.apache.org/r/56527/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message