mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 56527: Disallowed some special path components in IDs.
Date Thu, 23 Feb 2017 19:30:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56527/
-----------------------------------------------------------

(Updated Feb. 23, 2017, 11:30 a.m.)


Review request for mesos and James Peach.


Changes
-------

Comments. NNFR.


Summary (updated)
-----------------

Disallowed some special path components in IDs.


Bugs: MESOS-7086
    https://issues.apache.org/jira/browse/MESOS-7086


Repository: mesos


Description
-------

- Such IDs should lead to surprising or even dangerous agent side
directory structure.


Diffs (updated)
-----

  src/common/validation.cpp 028679d733d1aab65890d3782f18be0ddf3b05e9 
  src/tests/master_validation_tests.cpp 53771f6b5492009fe75cbbfc03a2b542856c1070 
  src/tests/slave_validation_tests.cpp 588c5b2a6b3528bbf7af8e724bc5813b05678bfb 

Diff: https://reviews.apache.org/r/56527/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message