mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 56530: Prevent resource of old agents being allocated to MULTI_ROLE frameworks.
Date Wed, 22 Feb 2017 02:30:04 GMT


> On Feb. 22, 2017, 5:30 a.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 214-241
> > <https://reviews.apache.org/r/56530/diff/6/?file=1640416#file1640416line214>
> >
> >     Can you pull this out into a separate patch?
> >     
> >     Also, I would suggest we just explicitly listen to the provided capabilities
and `FAIL() << "xxx"` if the caller is inconsistent (i.e. `roles.size() > 1 &&
!MULTI_ROLE`).

Per offline discussion, we will keep this as such and manually strip `MULTI_ROLE` in this
test case.


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56530/#review166229
-----------------------------------------------------------


On Feb. 20, 2017, 12:48 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56530/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2017, 12:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael
Park.
> 
> 
> Bugs: MESOS-6940
>     https://issues.apache.org/jira/browse/MESOS-6940
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In a mixed cluster, when an old agent (not MULTI_ROLE capable)
> registers with new master (MULTI_ROLE capable), it cannot correctly
> handle tasks from a MULTI_ROLE framework. Therefore, we should
> disallow resources from these agents being allocated to MULTI_ROLE
> frameworks.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c

>   src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a

> 
> Diff: https://reviews.apache.org/r/56530/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message