mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 56493: Port_mapping isolator: do not depend on interface speed.
Date Mon, 20 Feb 2017 18:07:45 GMT


> On Feb. 17, 2017, 10:51 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, lines 1601-1602
> > <https://reviews.apache.org/r/56493/diff/4/?file=1638725#file1638725line1601>
> >
> >     I would still return Error here.
> 
> Pierre Cheynier wrote:
>     I do not agree on that part. Here is what I experience and it's the reason of this
review:
>     ```
>     $ ls -la /sys/class/net/team0/speed
>     -r--r--r-- 1 root root 4096 Feb 20 12:17 /sys/class/net/team0/speed
>     # file /sys/class/net/team0/speed
>     /sys/class/net/team0/speed: ERROR: cannot read (Invalid argument)
>     # cat /sys/class/net/team0/speed
>     cat: /sys/class/net/team0/speed: Invalid argument
>     ```
> 
> Jie Yu wrote:
>     Ah, ok, let me change this back.

Fixed.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56493/#review165973
-----------------------------------------------------------


On Feb. 17, 2017, 3:51 p.m., Pierre Cheynier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56493/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2017, 3:51 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7074
>     https://issues.apache.org/jira/browse/MESOS-7074
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since a lot of environments do not provide interface speed in
> /sys/class/net/<ifname>/speed`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp f6f2bfe1d5d3c113036ad44a480f97bbb462a269

> 
> Diff: https://reviews.apache.org/r/56493/diff/
> 
> 
> Testing
> -------
> 
> ./configure
> make -j 8
> make check
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message