mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 56493: Port_mapping isolator: do not depend on interface speed.
Date Fri, 17 Feb 2017 22:51:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56493/#review165973
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (line 1597)
<https://reviews.apache.org/r/56493/#comment237833>

    We don't add period in log lines.



src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (lines 1601 - 1602)
<https://reviews.apache.org/r/56493/#comment237834>

    I would still return Error here.


- Jie Yu


On Feb. 17, 2017, 3:51 p.m., Pierre Cheynier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56493/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2017, 3:51 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7074
>     https://issues.apache.org/jira/browse/MESOS-7074
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since a lot of environments do not provide interface speed in
> /sys/class/net/<ifname>/speed`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp f6f2bfe1d5d3c113036ad44a480f97bbb462a269

> 
> Diff: https://reviews.apache.org/r/56493/diff/
> 
> 
> Testing
> -------
> 
> ./configure
> make -j 8
> make check
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message