mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 56053: Added a 'SECRET' type to the 'Environment' protobuf message.
Date Wed, 15 Feb 2017 23:20:46 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 15, 2017, 11:20 p.m.)

Review request for mesos, Adam B, Jie Yu, Kapil Arya, Jan Schlicht, and Vinod Kone.


Refactored tests and added null-byte secret validation.

Bugs: MESOS-7009

Repository: mesos


This patch adds a field of type `Secret` to the
`Environment` protobuf message, enabling the passing
of secrets into the environments of executors and
tasks. Additional validation and test code is added
as well.

Diffs (updated)

  include/mesos/mesos.proto 34a288b6f5c2fca090a7aa7a61798e3255d6663a 
  include/mesos/v1/mesos.proto 6638111d10f4a36cdf91dfce1019871e9839c306 
  src/common/validation.hpp 7946f06cf17c05893ff80179c9d14b5f1f4023ef 
  src/common/validation.cpp 0f1a02286d8431acfee6136e8ada49b0ac746897 
  src/tests/check_tests.cpp b5a5d8e80c80b480992a3c8160ee7d0e4443111c 
  src/tests/health_check_tests.cpp 476e04a12f885e5060a6e838b82ee599594c96f7 
  src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26 
  src/tests/slave_validation_tests.cpp 3d17799ed04951fb56524db0f5d89347192300b2 



`make check`


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message