mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 56530: Prevent offers for old agents being sent to MULTI_ROLE frameworks.
Date Wed, 15 Feb 2017 06:44:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56530/
-----------------------------------------------------------

(Updated Feb. 15, 2017, 2:44 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.


Bugs: MESOS-6940
    https://issues.apache.org/jira/browse/MESOS-6940


Repository: mesos


Description
-------

In a mixed cluster, when an old agent (not MULTI_ROLE capable)
registers with new master (MULTI_ROLE capable), it cannot correctly
handle tasks from a MULTI_ROLE framework. Therefore, we should
disallow offers from these agents being sent to MULTI_ROLE frameworks.


Diffs (updated)
-----

  src/master/master.cpp dff320acd1a13995d51cc0c303edea0cdfaa336d 
  src/tests/master_tests.cpp c8ef9d6bd9f4f8d631ac87d5e5f8dbe679a70fd1 

Diff: https://reviews.apache.org/r/56530/diff/


Testing
-------

./bin/mesos-tests.sh --gtest_filter="MasterTest.MultiRoleFrameworkDoesNotReceiveOfferFromOldAgent"
--gtest_break_on_failure --gtest_repeat=-1


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message