mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.
Date Tue, 14 Feb 2017 23:11:16 GMT


> On Feb. 14, 2017, 11:05 p.m., Joseph Wu wrote:
> > When we switched `mkdtemp` (directory version), that exposed some odd behavior on
OSX due to how lengthy OSX's default temporary directory is.  The IO Switchboard tests there
ran into a 108 character limit for Unix sockets.  It appears that this patch does not have
as many side effects (as we create fewer temporary files than we do temporary directories).

I should have written that I tested this in OS X also. Thanks for being thorough!


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56504/#review165582
-----------------------------------------------------------


On Feb. 9, 2017, 5:57 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56504/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 5:57 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Made `os::mktemp` fully cross-platform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/mktemp.hpp 231234f7652937e042f49b13fe8fc3c7193d26e1

> 
> Diff: https://reviews.apache.org/r/56504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message