mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.
Date Tue, 14 Feb 2017 23:05:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56504/#review165582
-----------------------------------------------------------


Ship it!




When we switched `mkdtemp` (directory version), that exposed some odd behavior on OSX due
to how lengthy OSX's default temporary directory is.  The IO Switchboard tests there ran into
a 108 character limit for Unix sockets.  It appears that this patch does not have as many
side effects (as we create fewer temporary files than we do temporary directories).

- Joseph Wu


On Feb. 9, 2017, 9:57 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56504/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 9:57 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Made `os::mktemp` fully cross-platform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/mktemp.hpp 231234f7652937e042f49b13fe8fc3c7193d26e1

> 
> Diff: https://reviews.apache.org/r/56504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message