mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 56530: Prevent offers for old agents being sent to MULTI_ROLE frameworks.
Date Tue, 14 Feb 2017 03:43:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56530/
-----------------------------------------------------------

(Updated Feb. 14, 2017, 11:43 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.


Bugs: MESOS-6940
    https://issues.apache.org/jira/browse/MESOS-6940


Repository: mesos


Description
-------

In a mixed cluster, when an old agent (not MULTI_ROLE capable)
registers with new master (MULTI_ROLE capable), it cannot correctly
handle tasks from a MULTI_ROLE framework. Therefore, we should
disallow offers from these agents being sent to MULTI_ROLE frameworks.


Diffs (updated)
-----

  include/mesos/master/master.proto 472348ba20dfd746c713bbeb6a429919943e5935 
  include/mesos/v1/master/master.proto 9d2f38e0b12f5f2c8a233db8f32bb48918cf6df0 
  src/common/protobuf_utils.hpp 4f69483d9ab66b7b5f2213300e6111196c67a335 
  src/common/protobuf_utils.cpp 442184920521f372c535426f49155cb19980bf6d 
  src/master/http.cpp caa1fabb7a709d993ff711cc7803dd05000fa987 
  src/master/master.cpp dff320acd1a13995d51cc0c303edea0cdfaa336d 
  src/tests/containerizer/io_switchboard_tests.cpp 9031815f5711cf940315ab3d8538aa099b356847

  src/tests/master_tests.cpp c8ef9d6bd9f4f8d631ac87d5e5f8dbe679a70fd1 

Diff: https://reviews.apache.org/r/56530/diff/


Testing (updated)
-------

./bin/mesos-tests.sh --gtest_filter="MasterTest.MultiRoleFrameworkDoesNotReceiveOfferFromOldAgent"
--gtest_break_on_failure --gtest_repeat=-1


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message