mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 56392: Tightened test expecations in reservation-related tests.
Date Mon, 13 Feb 2017 15:38:17 GMT


> On Feb. 11, 2017, 1:02 a.m., Benjamin Mahler wrote:
> > src/tests/master_validation_tests.cpp, line 428
> > <https://reviews.apache.org/r/56392/diff/3/?file=1629535#file1629535line428>
> >
> >     Not yours, but we should take the backticks out the log message in a follow
up.

Appended that follow-up to this chain, https://reviews.apache.org/r/56601/.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/#review165210
-----------------------------------------------------------


On Feb. 13, 2017, 4:38 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56392/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 4:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change makes expected error strings in reservation
> validation-related tests explicit. This is to make sure that the
> observed errors match the expected ones.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26 
> 
> Diff: https://reviews.apache.org/r/56392/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message