mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.
Date Sat, 11 Feb 2017 00:47:21 GMT


> On Feb. 9, 2017, 2:10 p.m., Jan Schlicht wrote:
> > src/common/http.cpp, line 910
> > <https://reviews.apache.org/r/56476/diff/1/?file=1628067#file1628067line910>
> >
> >     s/name/httpAuthenticatorName/
> >     Just `name` feels too general.

I went with the compromise of `authenticatorName`.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/#review164922
-----------------------------------------------------------


On Feb. 11, 2017, 12:46 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56476/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2017, 12:46 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the Mesos code to allow master and agent
> to load multiple HTTP authenticator modules.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e 
> 
> Diff: https://reviews.apache.org/r/56476/diff/
> 
> 
> Testing
> -------
> 
> Still need to add tests which test the master and agent with multiple authenticator modules
loaded.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message