mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 55462: Validate resource reservation against allocated role.
Date Sat, 11 Feb 2017 00:01:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55462/#review165204
-----------------------------------------------------------




src/master/validation.cpp (lines 1612 - 1629)
<https://reviews.apache.org/r/55462/#comment237018>

    Looks like this needs a rebase against master? This block was removed and the roles are
no longer an option.



src/master/validation.cpp (lines 1659 - 1695)
<https://reviews.apache.org/r/55462/#comment237023>

    See my response to the thread in the previous review comments about validating case (2)
as well so that we can provide a better error message to the operators.



src/master/validation.cpp (lines 1665 - 1693)
<https://reviews.apache.org/r/55462/#comment237025>

    Is it possible to get the open and close quotes on the same lines for these error messages?
When on different lines we tend to forget to close them, e.g.
    
    ```
            return Error(
                "A reserve operation was attempted for a resource allocated to role"
                " '" + resource.role() + "'"
                ", but the framework only has roles"
                " '" + stringify(frameworkRoles.get()) + "'");
    ```



src/master/validation.cpp (lines 1667 - 1668)
<https://reviews.apache.org/r/55462/#comment237024>

    How about:
    
    A reserve operation was attempted on unallocated resources, but frameworks can only perform
reservations on allocated resources
    
    Or:
    
    A reserve operation was attempted on unallocated resource 'XXX', but frameworks can only
perform reservations on allocated resources



src/tests/master_validation_tests.cpp (lines 420 - 446)
<https://reviews.apache.org/r/55462/#comment237026>

    Looks good, did you want to test the other cases as well?


- Benjamin Mahler


On Feb. 10, 2017, 3:16 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55462/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2017, 3:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
> 
> 
> Bugs: MESOS-6730
>     https://issues.apache.org/jira/browse/MESOS-6730
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces validation of the 'AllocationInfo' of resources
> used in reservations.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 2bfca95713319a195e43e990cbc2dc5570b89c4e 
>   src/tests/master_validation_tests.cpp 0c2649089d7fd29eb021ac75c71e6a74368577dc 
> 
> Diff: https://reviews.apache.org/r/55462/diff/
> 
> 
> Testing
> -------
> 
> N/A yet.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message