mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 56466: Capture ELF interpreters in the ldd utility.
Date Thu, 09 Feb 2017 08:19:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56466/#review164873
-----------------------------------------------------------


Fix it, then Ship it!





src/linux/ldd.cpp (lines 85 - 88)
<https://reviews.apache.org/r/56466/#comment236710>

    IIUC we always need the ELF interpreter. It just so happens that on RHEL ld cache resolves
ld-linux-x86-64.so.2 to /lib64/ld-linux-x86-64.so.2 which by accident is also the interpret
path. So it's not that Ubuntu is special but we were just lucky on RHEL?
    
    If so, I'd remove the statement about Ubuntu because there may be other distros that behave
in like Ubuntu and not RHEL.


- Jiang Yan Xu


On Feb. 8, 2017, 3:51 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56466/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 3:51 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7060
>     https://issues.apache.org/jira/browse/MESOS-7060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The ELF interpreter (ie. program loader) path is not necessarily
> specified in the ELF dependencies section but we still need
> to capture is as a dependency of an executable program.
> 
> 
> Diffs
> -----
> 
>   src/linux/ldd.cpp dd5c9c55560dc2895763141393fdaf97be66a5a8 
> 
> Diff: https://reviews.apache.org/r/56466/diff/
> 
> 
> Testing
> -------
> 
> make check (Fedora, Ubuntu)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message