mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 56466: Use the stout ELF parser to collect Linux rootfs files.
Date Wed, 08 Feb 2017 23:34:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56466/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.


Bugs: MESOS-7060
    https://issues.apache.org/jira/browse/MESOS-7060


Repository: mesos


Description
-------

The dependencies for the programs we need in the Linux root
filesystem vary over time and across distributions. Since stout
has support for parsing the library dependencies of ELF binaries,
use this to collect the necessary dependencies when constructing
a root filesystem for the tests.


Diffs
-----

  src/linux/ldd.cpp dd5c9c55560dc2895763141393fdaf97be66a5a8 
  src/tests/containerizer/rootfs.hpp 9648638c1d4b1f1c49708e058e9b930c5ae32138 
  src/tests/containerizer/rootfs.cpp f11f126fa4f3130b6778bfe7e7d0f025a638f06e 

Diff: https://reviews.apache.org/r/56466/diff/


Testing
-------

make check (Fedora, Ubuntu)

```
vagrant@vagrant-ubuntu-trusty-64:~/mesos/build/src$ sudo ./mesos-tests --gtest_filter=*IsolatorTest.ROOT_*
...
[==========] 64 tests from 10 test cases ran. (85512 ms total)
[  PASSED  ] 64 tests.
```


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message