mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 55771: Rejected optimizing if we are working with a libcxx with UB.
Date Wed, 08 Feb 2017 02:54:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55771/#review164622
-----------------------------------------------------------




configure.ac 
<https://reviews.apache.org/r/55771/#comment236390>

    Lets keep this one.


- Till Toenshoff


On Feb. 7, 2017, 7:49 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55771/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 7:49 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-6606
>     https://issues.apache.org/jira/browse/MESOS-6606
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 1478ad4dd3b20fc768fd679f81d803acf0995ad2 
>   configure.ac 60ffa0e6a0dc590af929ab8a011b6d78f82a48e0 
>   src/launcher/default_executor.cpp 8e942c6faf6e2dbc70a6fff1629343c9a3ce8668 
>   src/oci/spec.cpp 0a88edb404836205f11e61ba3edb771df8b618ef 
>   src/tests/default_executor_tests.cpp 1afab8292c7fc15bd16bee4bcd93ce290a233c9a 
> 
> Diff: https://reviews.apache.org/r/55771/diff/
> 
> 
> Testing
> -------
> 
> Tested on OS X Sierra with both bundled clang+stdlib and versions close to their HEADs
with
> 
>     $ autoreconf -fi && ./configure CXX=/usr/bin/clang++
>     $ autoreconf -fi && ./configure CXX=clang++  # versions from HEAD
> 
>     $ autoreconf -fi && ./configure --enable-optimize CXX=/usr/bin/clang++
>     $ autoreconf -fi && ./configure --enable-optimize CXX=clang++  # versions
from HEAD
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message