mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 56410: Increased granularity of environment handling in command executor.
Date Wed, 08 Feb 2017 00:58:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56410/
-----------------------------------------------------------

(Updated Feb. 7, 2017, 4:58 p.m.)


Review request for mesos, Jie Yu and Kevin Klues.


Changes
-------

Added a TODO for Windows.


Bugs: MESOS-7027
    https://issues.apache.org/jira/browse/MESOS-7027


Repository: mesos


Description
-------

This adds a new flag to the command executor `--task_environment`
which allows isolators to specify additionaly environment the task
should be given.  This flag is subject to the same priority as other
environment.  User-specified environment is first, isolator's second,
and agent environment last (i.e. `os::environment` from the executor's
context).

This also changes how the task itself receives these environment
variables.  The task is now given the environment explicitly, rather
than inheriting the executor's environment.  This will help prevent
isolators from accidently breaking the command executor or health
checks with task-specific environment variables.


Diffs (updated)
-----

  src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9 
  src/launcher/posix/executor.hpp d057ff6211a77e681ee80599d2ec5851a2fa6785 
  src/launcher/posix/executor.cpp 4bc0b0f1a09bf1579ff9612f812f09a3061883ce 

Diff: https://reviews.apache.org/r/56410/diff/


Testing
-------

Testing later in the chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message