mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 54784: Adds tests for authorization when attaching to a container input.
Date Wed, 08 Feb 2017 00:57:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/#review164581
-----------------------------------------------------------


Fix it, then Ship it!




Could you add the relevant JIRA, MESOS-6886? Also, the commit message should be in the past
tense.


src/tests/api_tests.cpp (line 4313)
<https://reviews.apache.org/r/54784/#comment236362>

    Could you include a comment above the test saying explicitly what we are testing here?



src/tests/api_tests.cpp (lines 4370 - 4371)
<https://reviews.apache.org/r/54784/#comment236368>

    Is this comment still accurate?


- Greg Mann


On Dec. 15, 2016, 3:34 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54784/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds tests for authorization when attaching to a container input.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16 
> 
> Diff: https://reviews.apache.org/r/54784/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message