mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 54783: Added tests for authorization of launching container sessions.
Date Wed, 08 Feb 2017 00:12:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54783/#review164582
-----------------------------------------------------------


Fix it, then Ship it!




Could you add the relevant JIRA, MESOS-6886?


src/tests/api_tests.cpp (line 3864)
<https://reviews.apache.org/r/54783/#comment236361>

    Could you include a comment before this test case which says explicitly what we're testing
here?



src/tests/api_tests.cpp (lines 3885 - 3886)
<https://reviews.apache.org/r/54783/#comment236348>

    Indent just two spaces:
    ```
      mesos::ACL::LaunchNestedContainerSessionUnderParentWithUser* acl =
        flags.acls.get()
          .add_launch_nested_container_sessions_under_parent_with_user();
    ```



src/tests/api_tests.cpp (lines 3922 - 3923)
<https://reviews.apache.org/r/54783/#comment236360>

    Update this comment?


- Greg Mann


On Dec. 15, 2016, 3:33 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54783/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2016, 3:33 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a unit test which checks authorization when launching
> a nested container session.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16 
> 
> Diff: https://reviews.apache.org/r/54783/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message