mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 56409: Enabled flag parsing of the 'Environment' protobuf.
Date Tue, 07 Feb 2017 23:36:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56409/#review164586
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 7, 2017, 10:16 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56409/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 10:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Kevin Klues.
> 
> 
> Bugs: MESOS-7027
>     https://issues.apache.org/jira/browse/MESOS-7027
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds 'mesos::Environment' to the template specializations
> required for stout flags to parse the protobuf directly.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 632a7e53b1604a6234ed231eaedf1efb2eafde5f 
>   src/common/parse.hpp 1dca9ba4ed4ff2163193ab6432b5b017d2be787e 
>   src/common/type_utils.cpp 516d3094ef50aa368ec61c2c784f38b393c7e24a 
> 
> Diff: https://reviews.apache.org/r/56409/diff/
> 
> 
> Testing
> -------
> 
> Testing later in the chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message