mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 56341: Updated AppC & Docker runtime isolators' handling of Environment.
Date Tue, 07 Feb 2017 22:26:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56341/
-----------------------------------------------------------

(Updated Feb. 7, 2017, 2:26 p.m.)


Review request for mesos, Jie Yu and Kevin Klues.


Changes
-------

Oops, forgot to update the summary/description.


Summary (updated)
-----------------

Updated AppC & Docker runtime isolators' handling of Environment.


Bugs: MESOS-7027
    https://issues.apache.org/jira/browse/MESOS-7027


Repository: mesos


Description (updated)
-------

This commit builds upon the command executor's new `--task_environment`
flag, which allows isolators to specify environment variables meant
for the task, without affecting the executor's environment.

This is important as the command executor is both an executor and
a task.  Some environment variables from isolators are intended
for the executor, while others are intended for the task (such as
from the two runtime isolators).

For example, a container image may provide an environment variable
like `LD_LIBRARY_PATH=/image/specific/location`, whereas the default
executor expects to find libraries in the host's environment.  If the
image's environment end up in the command executor at launch time,
the command executor may simply fail to launch.


Diffs
-----

  src/slave/containerizer/mesos/isolators/appc/runtime.cpp 9bc3fd8309435846c17944e74f611212069dbd76

  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 2d816e512c95ed2922c9578ba796908c5ce23da4


Diff: https://reviews.apache.org/r/56341/diff/


Testing
-------

make check

sudo src/mesos-tests --gtest_filter="*ROOT*"

All the tests broken by https://reviews.apache.org/r/56339/ (earlier in the chain) are now
passing.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message