mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 55771: Rejected optimizing if we are working with a libcxx with UB.
Date Tue, 07 Feb 2017 17:32:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55771/#review164527
-----------------------------------------------------------




configure.ac (line 1891)
<https://reviews.apache.org/r/55771/#comment236289>

    Sorry for not noticing ealier but I believe the idiomatic autotools way here is to use
a pair of `AC_MSG_CHECKING([string])`, `AC_MSG_RESULT([string])`. We could then have the failure
message follow that result; something along these lines, I guess....
    
    ```
    AC_MSG_CHECKING([C++ standard library has undefined behaviour with selected optimization
level])
    AC_LANG_PUSH([C++])
    AC_RUN_IFELSE([
      AC_LANG_SOURCE([[
      [...]
      ]])],
      [message='no'], [message='yes']
    )
    AC_MSG_RESULT([$message])
    
    if test "x$message" = "xyes"; then
      AC_MSG_ERROR([Mesos cannot be built with optimizations against this version of libcxx
(MESOS-5745).
                      Consider building without optimizations, or changing the used C++ standard
library.])
    fi
    ```
    
    ...which would look like this;
    
    ```
    Checking C++ standard library has undefined behaviour with selected optimization level...
no
    ```


- Till Toenshoff


On Jan. 23, 2017, 11:33 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55771/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2017, 11:33 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-6606
>     https://issues.apache.org/jira/browse/MESOS-6606
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   configure.ac 60ffa0e6a0dc590af929ab8a011b6d78f82a48e0 
> 
> Diff: https://reviews.apache.org/r/55771/diff/
> 
> 
> Testing
> -------
> 
> Tested on OS X Sierra with both bundled clang+stdlib and versions close to their HEADs
with
> 
>     $ autoreconf -fi && ./configure CXX=/usr/bin/clang++
>     $ autoreconf -fi && ./configure CXX=clang++  # versions from HEAD
> 
>     $ autoreconf -fi && ./configure --enable-optimize CXX=/usr/bin/clang++
>     $ autoreconf -fi && ./configure --enable-optimize CXX=clang++  # versions
from HEAD
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message