mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 56236: Add `syntax = "proto2"` to some files automatically.
Date Mon, 06 Feb 2017 16:57:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56236/#review164361
-----------------------------------------------------------



When we going to commit this, note that we need to send to dev@mesos.apache.org about this.
So other develpers would not foget to add `syntax 2` in protobuf files..

- haosdent huang


On Feb. 2, 2017, 8:12 p.m., Anthony Sottile wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56236/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 8:12 p.m.)
> 
> 
> Review request for mesos, Deshi Xiao, Yong Tang, and Zhitao Li.
> 
> 
> Bugs: MESOS-5186 and MESOS-6138
>     https://issues.apache.org/jira/browse/MESOS-5186
>     https://issues.apache.org/jira/browse/MESOS-6138
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> I used this pipeline:
> 
>     # Find all proto files with the 15-line license and add the syntax line
>     # after that
>     git grep -n 'limitations under the License' -- '*.proto' |
>         grep ':15' | cut -d':' -f1 |
>         xargs sed -i '16isyntax = "proto2";'
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 775c14b70c94c90d31d0123f45188fd29651f9f4 
>   include/mesos/allocator/allocator.proto 9fc8baccb135c5aa58f64847307978139139a46e 
>   include/mesos/appc/spec.proto 2dbb3504596dda229c42353098879350c3a7c960 
>   include/mesos/authentication/authentication.proto a24d53512a8ec27e97cf543cd64129c8a096ac67

>   include/mesos/authorizer/acls.proto fd25e5449ad659ee0269cfc3f47b9939ac022fb4 
>   include/mesos/authorizer/authorizer.proto 8b860a3e8e0b1c660a8fefc97f10f5acc0501920

>   include/mesos/docker/spec.proto 734395cbde81bc4ff99f1310fc4b913beeb5b11f 
>   include/mesos/docker/v1.proto 209fb4afe5e4ea1cc776bfe9cb36865c9b05aaf0 
>   include/mesos/docker/v2.proto 9b5bfb5d03ae8115c1b20a8c640640d6dbaa257d 
>   include/mesos/executor/executor.proto e746608176245bcabf265925111b8df9cab8ca55 
>   include/mesos/fetcher/fetcher.proto 7f204e1a0b70ecdcd4247e1c0699585243a97b40 
>   include/mesos/maintenance/maintenance.proto 4afae5c6958a5da91b3e649b496b9757d951ca0c

>   include/mesos/master/master.proto a2228db8902c297f137b8106a7b3d2babbc35017 
>   include/mesos/mesos.proto 53885cbc63ac6658a749da5e05bb2301392f84dd 
>   include/mesos/module/hook.proto f7b91f813f7919098763790211d3b90aed0b8340 
>   include/mesos/module/module.proto 1c6c4b0762f5a4e71cf64fd9bc859e380222b591 
>   include/mesos/quota/quota.proto 78e12d56c4f41613ec6b731d86093f48a23b4509 
>   include/mesos/scheduler/scheduler.proto 5f4635d523286754a61aa99e18e79d6c1db9463f 
>   include/mesos/slave/containerizer.proto c70d437ac3f8f813fcb71c04275cc8eeeb946065 
>   include/mesos/slave/oversubscription.proto e7346089d5699194b761c81ab9610ad33d83ba55

>   include/mesos/state/state.proto 7a7d68e6abc85c0ead04f5771e878d10348f44b8 
>   include/mesos/uri/uri.proto 55023b681665e712990d45ff4a1dbc4ccf64edbf 
>   include/mesos/v1/agent/agent.proto a98acb7b0c66f7e17dcecf61ed22bfde70a33651 
>   include/mesos/v1/allocator/allocator.proto 093f18f554470b14905db157bcc1e33303423eaa

>   include/mesos/v1/executor/executor.proto 754e62aee5f822526eb9661aa255444c3f84dd1d 
>   include/mesos/v1/maintenance/maintenance.proto 27f7c2b3460fe3a7e1a845cd962cb9979a9ccc0b

>   include/mesos/v1/master/master.proto cfdca7400d98233c6320eebd8784e4f51c43ebbd 
>   include/mesos/v1/mesos.proto c4ca6dea787cfe4661c9f0d9afb770bceb1c2639 
>   include/mesos/v1/quota/quota.proto 424e6b4bf0064d146cfeeb19de77f0cce67882b9 
>   include/mesos/v1/scheduler/scheduler.proto 096c76dfffe03c0e2d6abe84d438c396cc1b0be9

>   src/master/registry.proto eab9821b6d159d14bf62b347d61999988608ae5c 
>   src/messages/flags.proto 08406b69acaa52eba58e6091b9c8b3bc03981044 
>   src/messages/log.proto 12c2d83d88bb5b282bc44d49655a67e671b12ba2 
>   src/messages/messages.proto 7a2f37b78a8edcd372558f77f15e6b249742e321 
>   src/messages/state.proto 857a88873681c9cd7263d0063e8f17f08c5cd64b 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.proto 4c5b03c1a802c177f64ea8bb1e31fa58603991bb

>   src/slave/containerizer/mesos/isolators/network/cni/spec.proto 4b3850037ec01969cabf16b94745c1802bf4de62

>   src/slave/containerizer/mesos/provisioner/docker/message.proto c93c7a92ec152bd9747a70392adfe6a0e863e839

> 
> Diff: https://reviews.apache.org/r/56236/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Sottile
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message