mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 54601: Replaced `int` with `int_fd` in stout.
Date Sun, 05 Feb 2017 07:11:17 GMT


> On Feb. 2, 2017, 11:47 a.m., Alex Clemmer wrote:
> > 3rdparty/stout/include/stout/os/mktemp.hpp, line 44
> > <https://reviews.apache.org/r/54601/diff/5/?file=1600472#file1600472line44>
> >
> >     This also seems to be not a correct comparison? See the comment in `io::read`
in https://reviews.apache.org/r/54602/

We explicitly support these comparisons, and they're handled by the complex logic in `operator<`
for `WindowsFD`.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54601/#review164009
-----------------------------------------------------------


On Feb. 4, 2017, 5:39 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54601/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2017, 5:39 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced `int` with `int_fd` in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/net.hpp 4803aeb2fc1c89d42a02c631ef0450d5053ea8a2 
>   3rdparty/stout/include/stout/os/mktemp.hpp 2dfd35605eb4202a5475fe0e0d2f1fd27690a2de

>   3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 
>   3rdparty/stout/include/stout/os/posix/socket.hpp 041f00083c595c335146048c8685c4f96226b8e8

>   3rdparty/stout/include/stout/os/read.hpp d0b657db5b7dc0c1e11edc13fd6830a9f6273867 
>   3rdparty/stout/include/stout/os/socket.hpp e9d9306e63aff2be083b4254fbf6f31c37edc424

>   3rdparty/stout/include/stout/os/sunos.hpp e0398d25c0a5d0b55934594dd59b2629957ab921

>   3rdparty/stout/include/stout/os/touch.hpp 84d49bb8adc2612e380f037fd42c47166d55f593

>   3rdparty/stout/include/stout/os/windows/close.hpp 9f1566bff19ee872418bce8a43a119c4f0a70a7c

>   3rdparty/stout/include/stout/os/windows/fcntl.hpp f331cd324bc609f5b8081fa86d66d9947daf04f6

>   3rdparty/stout/include/stout/os/windows/fsync.hpp e1c4868b02b320906f446af1d9371374e90651bc

>   3rdparty/stout/include/stout/os/windows/ftruncate.hpp a7f53ad2e8735b515590af84c0efce3edcc1bebf

>   3rdparty/stout/include/stout/os/windows/read.hpp 09190f97f33db5dfa023f937f8f2a4a62ed1ec15

>   3rdparty/stout/include/stout/os/windows/sendfile.hpp d6358cc02c1eea9298907da1f74eb7eeaeec7d21

>   3rdparty/stout/include/stout/os/windows/shell.hpp 46a0b1d1a52648710dd82188072c0f9f24ac272d

>   3rdparty/stout/include/stout/os/windows/socket.hpp c787341181da53abc5a3b2eadc76c85fef181310

>   3rdparty/stout/include/stout/os/windows/write.hpp e0f2f0d4d4168105357d6f98f2dc2800124d37e4

>   3rdparty/stout/include/stout/os/write.hpp 9bb9fbd4593866b6193a1e253e65852da0ff5ed5

>   3rdparty/stout/include/stout/protobuf.hpp 80cb20f40a7ddd4309d27973eef9fca9e4052b64

>   3rdparty/stout/include/stout/windows.hpp 82387049895066ed9a1dcc48d11c236199ee8146 
>   3rdparty/stout/include/stout/windows/os.hpp c123772ab018d327b02dacfb314b835b9f373cfc

>   3rdparty/stout/tests/os/filesystem_tests.cpp 22460842c0db5dc5b6effbc2bdfce043ed47db6d

>   3rdparty/stout/tests/os/sendfile_tests.cpp 17e10d92a0a004cb7ac83f4ff9c71844418a35b0

>   3rdparty/stout/tests/os_tests.cpp 31a4c8f1114fb7922c5819c3b844885e80e09906 
>   3rdparty/stout/tests/path_tests.cpp 8275e38a503e64d242da6be0fe6bd0a0c21869a3 
> 
> Diff: https://reviews.apache.org/r/54601/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message