mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 55972: Updated master to handle non-MULTI_ROLE agents.
Date Sat, 04 Feb 2017 03:02:44 GMT


> On Feb. 1, 2017, 11:55 p.m., Michael Park wrote:
> > src/master/master.cpp, lines 5620-5628
> > <https://reviews.apache.org/r/55972/diff/1/?file=1617174#file1617174line5620>
> >
> >     The state of `AllocationInfo` is fully determined by `MULTI_ROLE` capability
of the agent, right? Even in the downgrade scenario, the agent would ignore the `AllocationInfo`
during recover and send over `Resource`s without `AllocationInfo` set?

Not quite, in the downgrade the agent will keep the unknown allocation_info field since protobuf
does not strip them.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55972/#review163902
-----------------------------------------------------------


On Jan. 27, 2017, 12:29 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55972/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 12:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Park.
> 
> 
> Bugs: MESOS-6968
>     https://issues.apache.org/jira/browse/MESOS-6968
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With the addition of MULTI_ROLE framweork support, allocated
> resources have a `Resource.AllocationInfo` set. While the new
> MULTI_ROLE capable agents will be sending allocated resources,
> the old agents may not be since they may not preserve the
> unknown fields.
> 
> To cope with this, the master ensures the `Resource.AllocationInfo`
> is set for non-MULTI_ROLE capable agents, by injecting it. Note
> that we can only do this so long as it is unambiguous! This will
> be prevented by not allowing frameworks with multiple to use
> agents without the MULTI_ROLE support, see: MESOS-6940.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 7e38af41ca16241dbbe3bc2e80c0848e82762a45 
>   src/master/master.cpp 0f2c7cd32161576fad742ef350dff64874b80854 
> 
> Diff: https://reviews.apache.org/r/55972/diff/
> 
> 
> Testing
> -------
> 
> The tests pass at the end of this review chain.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message