mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 56188: Removed all instances of '.Times(1)' from libprocess tests.
Date Thu, 02 Feb 2017 10:16:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56188/#review163953
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Schlicht


On Feb. 1, 2017, 10:26 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56188/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 10:26 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using `.Times(1)` with `EXPECT_CALL` is redundant, as this
> is implied by default. This patch removes all such remaining
> occurrences from the libprocess tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp cd159b6dbde44d89bca76c6ec99cc22621638b2a

> 
> Diff: https://reviews.apache.org/r/56188/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message