mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 56187: Removed all instances of '.Times(1)' from Mesos tests.
Date Thu, 02 Feb 2017 10:16:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56187/#review163952
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Schlicht


On Feb. 1, 2017, 10:26 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56187/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 10:26 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using `.Times(1)` with `EXPECT_CALL` is redundant, as this
> is implied by default. This patch removes all such remaining
> occurrences from the Mesos tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 7d728547da9fae0e169890add06fc9c2b26a447f 
>   src/tests/containerizer/cgroups_isolator_tests.cpp ba268b6918be0e7226a975c38eff5620b076083f

>   src/tests/containerizer/cpu_isolator_tests.cpp d61a8dc579ca95ae5a926ceab80f8efe4098bf91

>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp d5332abd6f7bd9b3fce635d3db9202b6a56a1586

>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp c27335731924509632ec96cc01a4b4415f108a30

>   src/tests/containerizer/memory_isolator_tests.cpp bcf8e8920ed5e1e1e3d6a3c4f4e33fd5451fb87a

>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp fc57e237cf13d7423614d43bee9d43c783732e7c

>   src/tests/exception_tests.cpp 7b66bd1b0beb004641fe0a08e02db168f2653354 
>   src/tests/fetcher_cache_tests.cpp 7dfc822ee4e1c9fe432b749bacf08e07ee50abf1 
>   src/tests/gc_tests.cpp d9776b602bee780b9732cd93d06b9c8f3cc8a4d0 
>   src/tests/master_authorization_tests.cpp f973cf49cb07d2acc762997003309327ae49992a 
>   src/tests/master_contender_detector_tests.cpp d41caeae19919ad1ff0693d59b64d8a6b385678d

>   src/tests/master_maintenance_tests.cpp 9861d1186e046a4fd547e73825c02b71eedd5ce2 
>   src/tests/master_tests.cpp da7094dbbafbb0ab1153a0a4a6fcabd63888d67a 
>   src/tests/rate_limiting_tests.cpp f105b67cd1f52ece6dcf8ca849f11b63e3d7dfa0 
>   src/tests/reconciliation_tests.cpp fc0ff9137c13f839731d8f228423b05f386463b5 
>   src/tests/registrar_zookeeper_tests.cpp 598a93059b062438f0bebb5273e6965604db39fc 
>   src/tests/resource_offers_tests.cpp 72ceb8696a7277f9add6d89adb55aa08665bdeb5 
>   src/tests/slave_recovery_tests.cpp 9cf1d461cf5c6ac1f51ac963360a17e37f558505 
>   src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7 
>   src/tests/status_update_manager_tests.cpp 2d2f1ec82559dab9b8f7bf043cf23f38b7423fcb

> 
> Diff: https://reviews.apache.org/r/56187/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message